Add fleet management grid sample #10
Conversation
IMinchev64
added
the
🛠️ status: in-development
IMinchev64
removed
the
🛠️ status: in-development
This comment was marked as resolved.
This comment was marked as resolved.
IMinchev64
added
the
🛠️ status: in-development
IMinchev64
added
❌ status: awaiting-test
|
If running the app with the latest changes after the "Refactor structure of data and data handling" commit you should delete the |
dkamburov
added
❌ status: awaiting-test
|
| private driverOverlayId: string | null = null; | ||
|
|
||
| //overlay toggle flags | ||
| public isLocationOverlayActive = false; |
There was a problem hiding this comment.
For consistency can you assign type boolean to these two variables as well
|
|
||
| //chart periods | ||
| public periods = { | ||
| costPerTypePeriod: "ytd", |
There was a problem hiding this comment.
These values are used in several places ("ytd", "3months", "6months", "12months") . Can you put them in an Enum or some shared object?
| } | ||
|
|
||
| //driver details for detail overlay | ||
| public driverDetails = { |
There was a problem hiding this comment.
Interface for this so that you can assign a type to it
|
|
||
| //handling for chart periods | ||
| public onPeriodChange(event: any, chart: string): void { | ||
| if (chart == "costsPerType") { |
There was a problem hiding this comment.
Is there any reason to use == instead of === ?
Also can you put all flying around strings in variables? If they are repeating over different files, please put them in a shared location.
|
|
||
| const driverDetails = this.dataService.getDriverData(driverName); | ||
|
|
||
| this.driverDetails.name = driverDetails?.name as string; |
There was a problem hiding this comment.
Please use driverDetails?.name || "" instead of "as string". This will ensure us that we have an empty string if driverDetails.name has a falsy value. Same goes for all of the fields following
…minchev/master-detail-grid
dkamburov
added
✅ status: verified
To-do: