Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue releasing to pypi #127

Closed
barneydobson opened this issue Nov 20, 2024 · 3 comments · Fixed by #128
Closed

issue releasing to pypi #127

barneydobson opened this issue Nov 20, 2024 · 3 comments · Fixed by #128

Comments

@barneydobson
Copy link
Collaborator

https://github.com/ImperialCollegeLondon/wsi/actions/runs/11932607759/job/33258089433

seems to work on the test deployment but not on actual publish... any ideas @dalonsoa ?

@dalonsoa
Copy link
Collaborator

Contrary to SWMManywhere, that uses hatchling to build the package, WSIMOD uses the good old setuptools. That means that creating a release with the corresponding tag does not automatically update the version number. The one set for WSIMOD is still 0.4.0, as indicated in pyproject.toml, which already exist in PyPI, regadless of the what they resease says and how many tags you create.

The options are:

  • Manually change the version number to 0.5.0 in pyproject.toml
  • Adopt hatchling, like SWMManywhere

@barneydobson
Copy link
Collaborator Author

I have found hatchling easier with SWMManywhere - but will that get confused since we have a variety of releases that do not follow 0.X.X convention? I remember that being an issues with SWMManywhere

@dalonsoa
Copy link
Collaborator

Not sure, to be honest. I've as much experience with hatchling as you do. I don't thin it should be a problem, but cannot say for sure. Maybe ask Taher.

This was referenced Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants