fix(SimpleResolver): Function loadOrResolve should be atomically performed #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uted in the serial queue
adrien-coye
force-pushed
the
fix/race-condition-in-loadOrResolve
branch
from
bb41451 to
83b9b96
Compare
|
|
This was an exploration of a potential bugfix, now superseded by a refactor branch #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
func loadOrResolve()can be called from any arbitrary thread, and can recursively be called within afactoryto resolve other types.The current implementation does allow for re-entry but can break under the right conditions.
Eg. Two objects 1 and 2 within a factory resolve the same root object A, we can end up with multiple calls to the A factory and have A and A-2 in memory
This PR aims at making sure
loadOrResolve()is performed in a singlequeue.synccall while correctly handling the re-entry issue by not context switching to the internal serial queue if already on it.