refactor: Switch to recursive lock #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-coye
force-pushed
the
refactor/recursive-lock
branch
from
233fb27 to
ba2c0d8
Compare
|
This was referenced Mar 19, 2025
adrien-coye
commented
Mar 19, 2025
adrien-coye
added
enhancement
PhilippeWeidmann
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching
SimpleResolverto a recursive lock.This fixes a rare bug in
loadOrResolve(), reduce latency, and is now cleaner than an internal queue.In my synthetic tests, this is 19% faster than 2.0.3
More details in the exploratory PR