-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : change id generator for distribution and dataset #659
Merged
EmmanuelDemey
merged 10 commits into
main
from
651-remplacer-lidentifiant-pour-un-uuid-dans-jeux-de-donnes
Jul 4, 2024
Merged
fix : change id generator for distribution and dataset #659
EmmanuelDemey
merged 10 commits into
main
from
651-remplacer-lidentifiant-pour-un-uuid-dans-jeux-de-donnes
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no prefix and UUID version 4
EmmanuelDemey
requested changes
Jun 25, 2024
src/main/java/fr/insee/rmes/bauhaus_services/datasets/DatasetServiceImpl.java
Show resolved
Hide resolved
src/main/java/fr/insee/rmes/bauhaus_services/distribution/DistributionServiceImpl.java
Outdated
Show resolved
Hide resolved
FBibonne
requested changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On pourrait ajouter un test sur generateNextId qui vérifie que l'UUID généré est bien de la version 4
src/main/java/fr/insee/rmes/bauhaus_services/distribution/DistributionServiceImpl.java
Show resolved
Hide resolved
src/test/java/fr/insee/rmes/bauhaus_services/datasets/DatasetServiceImplTest.java
Outdated
Show resolved
Hide resolved
FBibonne
approved these changes
Jul 4, 2024
EmmanuelDemey
approved these changes
Jul 4, 2024
EmmanuelDemey
deleted the
651-remplacer-lidentifiant-pour-un-uuid-dans-jeux-de-donnes
branch
July 4, 2024 17:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no prefix and UUID version 4
#651