refactor: create enum class for label type #124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
"type"
property of label objects was implemented as aString
. Yet, only precise values are valid for Lunatic.➡️ The string property should be replaced with an enum
Goal: apply this change in a transparent way, to do it gradually.
Done
String getType()
andsetType(String)
are unchanged and marked as@Deprecated
LabelTypeEnum
classLabelTypeEnum getTypeEnum()
andsetType(LabelTypeEnum)
In a later version:
getType()
method will return aLabelTypeEnum
valuegetTypeEnum()
method will be marked as@Deprecated
In an even later version:
getTypeEnum()
method will be removed(In the end: it will be as if this property has always been an enum)