Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DaCapo #308

Merged
merged 6 commits into from
Nov 12, 2024
Merged

DaCapo #308

merged 6 commits into from
Nov 12, 2024

Conversation

pattonw
Copy link
Contributor

@pattonw pattonw commented Nov 2, 2024

Add the DaCapo project.

This isn't quite ready for a merge.
Am I using the tags right? I added almost all microscopy tags since DaCapo can train on and segment pretty much any type of volumetric data.

I think we also need a nicer image to use for the card. At the moment I am using the DaCapo logo but it is too low resolution and the wrong aspect ratio so it gets way too zoomed in.

@rhoadesScholar, @mzouink, @avweigel, @StephanPreibisch, @funkey
Does this look good to you all?

Copy link

github-actions bot commented Nov 2, 2024

🎉 Thank you for your contribution!

The website maintainers will review your PR soon.

@pattonw
Copy link
Contributor Author

pattonw commented Nov 2, 2024

Screenshot 2024-10-29 at 7 31 03 PM

@allison-truhlar
Copy link
Collaborator

@pattonw I added a background to the Dacapo icon to improve the appearance - see screenshot which is of the largest size card.

Screenshot 2024-11-08 at 1 52 39 PM

As for the tags, each project is free to use them how they like. Their purpose is to make it possible for visitors browsing the site to discover new software related to a given topic. You can use this as a guide when deciding what tags to include - for example, if you want Dacapo to show up when someone is looking for software related to electron microscopy, etc., then I would include the tag. I hope this helps. Let me know if you have additional questions or when you're ready for me to merge the PR.

@allison-truhlar allison-truhlar self-assigned this Nov 8, 2024
@pattonw
Copy link
Contributor Author

pattonw commented Nov 12, 2024

Awesome, thanks for adding the background to the logo to improve the card. That looks great. I'll review the pull request with the rest of the team tomorrow and see if there are any other changes I need to make before merging. I should be able to let you know afternoon if we're ready to merge

@pattonw
Copy link
Contributor Author

pattonw commented Nov 12, 2024

Good to go to merge this 👍
Thanks!

@allison-truhlar allison-truhlar marked this pull request as ready for review November 12, 2024 22:14
Copy link
Collaborator

@allison-truhlar allison-truhlar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding DaCapo to the site!

@allison-truhlar allison-truhlar merged commit d5ec370 into JaneliaSciComp:main Nov 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants