AsyncHook MemoryLeak fixes #60
Open
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankon
reviewed
Jun 13, 2020
| * in case our namespace is retained mistakenly, so | ||
| * we releasing heavist part at least | ||
| */ | ||
| namespace._contexts = null; |
There was a problem hiding this comment.
Couple of typos, and this shouldn't be JSDoc block. Maybe:
/*
* Zeroing _contexts as heaviest part of Namespace
* In case our namespace is retained mistakenly, so
* at least we are releasing heaviest part
*/
There was a problem hiding this comment.
Yeah, I agree with these changes. Thanks for suggestions.
|
@Jeff-Lewis ping( |
|
Any updates on this @Jeff-Lewis ? |
You haven't yet noticed that cls-hooked has a major memory leak? See: And btw: a performance problem as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we have to
disablehook, when namespace is destoryed. Otherwise it would live forever and hence it would retain namespace object with all it's massive _context.More details how I replicated and fixed the issue described here: liberation-data/drivine#35 (comment)