Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reexport commonly used array/view packages #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented Apr 16, 2021

Four packages are reexported by ImageCore:

  • IndirectArrays
  • MappedArrays
  • OffsetArrays
  • TiledIteration

The extra time overhead seems good to me. (Although in static compiled languages like C++ there's so-called best practice -- "what you don’t use, you don’t pay for", in Julia we still don't have a good solution for this, hence we need to make a tradeoff between the maintenance and overhead)

@time using ImageCore
# PR: 0.631698 seconds (1.17 M allocations: 86.323 MiB, 7.37% gc time, 0.52% compilation time)
# master: 0.565541 seconds (1.16 M allocations: 85.314 MiB, 6.02% gc time, 0.62% compilation time)

- IndirectArrays
- MappedArrays
- OffsetArrays
- TiledIteration
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #164 (34ea3d6) into master (5b2202d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   66.42%   66.42%           
=======================================
  Files          10       10           
  Lines         563      563           
=======================================
  Hits          374      374           
  Misses        189      189           
Impacted Files Coverage Δ
src/ImageCore.jl 71.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2202d...34ea3d6. Read the comment docs.

@johnnychen94
Copy link
Member Author

Since ColorVectorSpace 0.9 brings many new symbols, we might also want to reexport that, too.

@timholy
Copy link
Member

timholy commented Jun 16, 2022

FWIW I'm fine with this change if you want it (I haven't checked the costs myself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants