-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub workflow to run benchmark suite #51
Conversation
Edit: am using the dynamic library for OpenBLAS instead, and linking with |
fa6a819
to
a16cf00
Compare
The Lua benchmark seems out of date as well. |
The rest seem to be working. Ready for review. |
This is a great contribution. Thank you. |
run: | | ||
cd ~/ | ||
mkdir -p dSFMT | ||
cd dSFMT | ||
wget https://github.com/MersenneTwister-Lab/dSFMT/archive/refs/tags/v2.2.4.tar.gz | ||
echo "39682961ecfba621a98dbb6610b6ae2b7d6add450d4f08d8d4edd0e10abd8174 v2.2.4.tar.gz" | sha256sum --check --status | ||
tar -xzf v2.2.4.tar.gz | ||
mv dSFMT-*/* ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to use https://github.com/JuliaBinaryWrappers/dSFMT_jll.jl/releases/download/dSFMT-v2.2.4%2B2/dSFMT.v2.2.4.x86_64-linux-gnu.tar.gz instead? This is also what's used by Julia itself, so it'd make the comparison fairer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I can't. This BinaryBuilder version doesn't include the C source code (dSFMT.c), which is required by the benchmark.
It says it's built by the same version though, so I think it's fine?
Ping for review. Let me know if this is ready for merging. |
Sorry, I do not have write access. |
@StefanKarpinski @johnfgibson would one of you be willing to approve this? Thanks! |
Co-authored-by: Dilum Aluthge <[email protected]>
Thanks, all suggestions implemented. |
Co-authored-by: Mosè Giordano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it a try.
Thanks!! |
Thank you for your patience and your contribution, @MilesCranmer . |
GitHub actions are desirable for running benchmarks for a variety of reasons:
This GitHub action successfully runs a subset of the languages and generates the csv data. The workflow runs for the following languages:
The following benchmarks are not part of the workflow, for the reasons given below:
Current result (it prints the csv at the end):