Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub workflow to run benchmark suite #51
Create GitHub workflow to run benchmark suite #51
Changes from all commits
7999801
be74ccf
4a234c2
046ad04
287df3e
b762cf6
4fa9d4a
5fe7434
6d13d88
d6b6721
b3f0c13
de58980
2b6a3d4
72b7d44
90c55e8
6b5da95
e161813
be3ae82
80ee2d9
0ccc6c8
89fc84a
2055303
991eae9
88570dd
5002a95
547881c
426f69a
3a339cc
25762d4
f0bfea7
d8d07d8
18e6396
52b6a4a
46e5aad
90e171d
df6de3e
ea741a0
7f3401d
5ecbcbb
10be12b
e922655
3ca28e0
99c3b08
44c6b3b
5084231
0ec2b43
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to use https://github.com/JuliaBinaryWrappers/dSFMT_jll.jl/releases/download/dSFMT-v2.2.4%2B2/dSFMT.v2.2.4.x86_64-linux-gnu.tar.gz instead? This is also what's used by Julia itself, so it'd make the comparison fairer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I can't. This BinaryBuilder version doesn't include the C source code (dSFMT.c), which is required by the benchmark.
It says it's built by the same version though, so I think it's fine?