Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ManifoldDiff v0.4 #771

Merged
merged 14 commits into from
Nov 27, 2024

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Nov 24, 2024

  • Bump ManifoldDiff compat to v0.4.0
  • Remove import of AbstractDiffBackend

@gdalle gdalle changed the title Upgrade to next ManifoldsDiff with DI integration Upgrade to ManifoldsDiff v0.4, bump Julia compat to v1.10 Nov 24, 2024
NEWS.md Outdated Show resolved Hide resolved
@kellertuer
Copy link
Member

One thing that could be done here as well then, is to remove all the requires and using ..X tricks in the extension, since from 1.10 onwards they are not needed. But sure we can also do that on a next PR.

@gdalle
Copy link
Contributor Author

gdalle commented Nov 24, 2024

Good point, I'll do the Julia 1.10 upgrade first and then rebase this PR on it.

@gdalle gdalle changed the title Upgrade to ManifoldsDiff v0.4, bump Julia compat to v1.10 Upgrade to ManifoldsDiff v0.4 Nov 24, 2024
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (c0a2344) to head (818411b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files         124      124           
  Lines       11582    11582           
=======================================
  Hits        11161    11161           
  Misses        421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle closed this Nov 24, 2024
@gdalle gdalle reopened this Nov 24, 2024
@gdalle gdalle mentioned this pull request Nov 27, 2024
@gdalle gdalle marked this pull request as ready for review November 27, 2024 17:37
@gdalle
Copy link
Contributor Author

gdalle commented Nov 27, 2024

@kellertuer this should be good to go

@gdalle gdalle changed the title Upgrade to ManifoldsDiff v0.4 Upgrade to ManifoldDiff v0.4 Nov 27, 2024
@mateuszbaran mateuszbaran merged commit 66be9cc into JuliaManifolds:master Nov 27, 2024
18 checks passed
@gdalle gdalle deleted the gd/manifoldsdiff_update branch November 27, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants