Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Julia compat to 1.10 #772

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Nov 24, 2024

  • Bump Julia compat in Project.toml from 1.6 to 1.10
  • Bump Manifolds version to v0.10.8
  • Update CI to run on lts, 1 (stable) and pre (pre-release)
  • Remove Requires and its extension shenanigans

@gdalle gdalle mentioned this pull request Nov 24, 2024
2 tasks
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.36%. Comparing base (5bc3cd5) to head (b4394a9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   96.41%   96.36%   -0.06%     
==========================================
  Files         124      124              
  Lines       11590    11582       -8     
==========================================
- Hits        11175    11161      -14     
- Misses        415      421       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . I guess we could merge this and #770 and tag 0.10.8? Or is this PR not finished yet?

@mateuszbaran mateuszbaran marked this pull request as ready for review November 27, 2024 13:44
@mateuszbaran mateuszbaran merged commit c0a2344 into JuliaManifolds:master Nov 27, 2024
17 of 18 checks passed
@gdalle
Copy link
Contributor Author

gdalle commented Nov 27, 2024

Do you mean #771? If so, that PR is not ready yet, you first need to tag the breaking release v0.4.0 of ManifoldDiff

@gdalle gdalle deleted the gd/julia110 branch November 27, 2024 13:47
@mateuszbaran
Copy link
Member

Ah, sorry, I meant #772

@mateuszbaran
Copy link
Member

And #770, because it's also ready and could be a part of single 0.10.8 release. #771 will be left for later.

@mateuszbaran
Copy link
Member

I was a bit confused with the discussions split among multiple PRs 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants