Adapt to ManifoldsBase 1.0 #781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iaManifolds/Manifolds.jl into kellertuer/adapt-to-ManifoldsBase-16
….com/JuliaManifolds/Manifolds.jl into kellertuer/adapt-to-ManifoldsBase-16
kellertuer
changed the title
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on JuliaManifolds/ManifoldsBase.jl#221 being merged.
Overall I went through all occurrences of
expandexp!and split/renamed them toexptandexpt!, respectively, where necessary.There are two tricky areas left
MetricManifold, which should carefully be checkedsolve_exp_odewhere I can not yet see why they fail because the error messages basically kill my terminal in length.Formerly this is breaking, because we drop support for ManifoldsBase 0.15?
Furthermore all occurrences of
retract,retract_and all its follow up functions need to be split for each and every retraction method on every manifold.