Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to ManifoldsBase 1.0 #781

Merged
merged 38 commits into from
Feb 10, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
ef4c4f0
Adapt new function names and naming scheme.
kellertuer Jan 24, 2025
8411b6f
Already remove two fallbacks on hat, that cause ambiguities on Groups.
kellertuer Jan 24, 2025
6d8555d
runs formatter.
kellertuer Jan 25, 2025
255623f
mostly convert to retraction_t
mateuszbaran Jan 25, 2025
f3142cf
a few more fixes
mateuszbaran Jan 25, 2025
24acd74
Adapt to removal of the _along methods.
kellertuer Jan 26, 2025
722c6fa
Merge branch 'kellertuer/adapt-to-ManifoldsBase-16' of github.com:Jul…
kellertuer Jan 26, 2025
6a67d99
Merge branch 'kellertuer/adapt-to-ManifoldsBase-16' of https://github…
mateuszbaran Jan 26, 2025
268c1dd
more retraction fixes
mateuszbaran Jan 26, 2025
372651e
one more fix
mateuszbaran Jan 26, 2025
c589e84
fix ODE retraction
mateuszbaran Jan 26, 2025
1252478
nicer compat.
kellertuer Jan 27, 2025
0aac6d9
rename exp_t -> exp_fused
mateuszbaran Jan 31, 2025
5015202
Fix elliptope
kellertuer Feb 1, 2025
a539ca1
runs formatter.
kellertuer Feb 1, 2025
81b5940
fixing stuff
mateuszbaran Feb 1, 2025
c14cbd2
Merge branch 'kellertuer/adapt-to-ManifoldsBase-16' of https://github…
mateuszbaran Feb 1, 2025
cc24fa3
Fix most fused cases.
kellertuer Feb 1, 2025
75515a2
fix a test.
kellertuer Feb 1, 2025
40e5fa9
Fix two tests in SE(n) for hat/hat! where we checked they would not w…
kellertuer Feb 1, 2025
5c75d8d
Fix sasaki.
kellertuer Feb 1, 2025
f1e121c
Fix connection.
kellertuer Feb 1, 2025
acda8b7
Don't export the fused variants.
kellertuer Feb 1, 2025
ff1b56f
Fix two further tests.
kellertuer Feb 1, 2025
c289c50
A few final touches.
kellertuer Feb 1, 2025
51363d3
Undo an accidental renaming.
kellertuer Feb 5, 2025
92baf8a
Add deprecation bindings, test and document them.
kellertuer Feb 5, 2025
25e1b76
Fix a typo.
kellertuer Feb 5, 2025
4525786
Fix compat entries in docs and tutorials.
kellertuer Feb 5, 2025
2d2a9b0
bump ambiguities.
kellertuer Feb 5, 2025
243ce62
this method is not needed
mateuszbaran Feb 5, 2025
837047a
Towards code cov.
kellertuer Feb 7, 2025
81c8c82
add a few tests towards code coverage.
kellertuer Feb 7, 2025
90c28f0
Add references.
kellertuer Feb 7, 2025
ee8530b
Remove old code, that is no longer necessary, since we are on 1.10 at…
kellertuer Feb 7, 2025
c548a64
tweak docs.
kellertuer Feb 7, 2025
bfd984f
Ups. Forgot a marker.
kellertuer Feb 7, 2025
c596b2c
minor corrections
mateuszbaran Feb 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
runs formatter.
  • Loading branch information
kellertuer committed Jan 25, 2025
commit 6d8555d9c9d1461afe5ba80113612d339e7d8978
8 changes: 7 additions & 1 deletion ext/ManifoldsTestExt/tests_general.jl
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,13 @@ function test_manifold(
Test.@test isapprox(M, pts[1], exp(M, pts[2], X2); atol=atolp1p2, rtol=rtolp1p2)
end
Test.@test is_point(M, exp(M, pts[1], X1); atol=atolp1p2, rtol=rtolp1p2)
Test.@test isapprox(M, pts[1], ManifoldsBase.expt(M, pts[1], X1, 0); atol=atolp1p2, rtol=rtolp1p2)
Test.@test isapprox(
M,
pts[1],
ManifoldsBase.expt(M, pts[1], X1, 0);
atol=atolp1p2,
rtol=rtolp1p2,
)
for p in pts
epsx = find_eps(p)
Test.@test isapprox(
Expand Down
32 changes: 26 additions & 6 deletions src/groups/validation_group.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ function adjoint_action(M::ValidationManifold, p, X; kwargs...)
is_point(M, p; error=M.mode, kwargs...)
eM = Identity(M.manifold)
is_vector(M, eM, X; error=M.mode, kwargs...)
Y = ValidationTangentVector(adjoint_action(M.manifold, internal_value(p), internal_value(X)))
Y = ValidationTangentVector(
adjoint_action(M.manifold, internal_value(p), internal_value(X)),
)
is_vector(M, eM, Y; error=M.mode, kwargs...)
return Y
end
Expand All @@ -25,7 +27,9 @@ function adjoint_action!(M::ValidationManifold, Y, p, X; kwargs...)
end

Identity(M::ValidationManifold) = array_point(Identity(M.manifold))
identity_element!(M::ValidationManifold, p) = identity_element!(M.manifold, internal_value(p))
function identity_element!(M::ValidationManifold, p)
return identity_element!(M.manifold, internal_value(p))
end

function Base.inv(M::ValidationManifold, p; kwargs...)
is_point(M, p; error=M.mode, kwargs...)
Expand All @@ -45,7 +49,9 @@ function lie_bracket(M::ValidationManifold, X, Y)
eM = Identity(M.manifold)
is_vector(M, eM, X; error=M.mode)
is_vector(M, eM, Y; error=M.mode)
Z = ValidationTangentVector(lie_bracket(M.manifold, internal_value(X), internal_value(Y)))
Z = ValidationTangentVector(
lie_bracket(M.manifold, internal_value(X), internal_value(Y)),
)
is_vector(M, eM, Z; error=M.mode)
return Z
end
Expand Down Expand Up @@ -129,7 +135,9 @@ function inverse_translate(
)
is_point(M, p; error=M.mode, kwargs...)
is_point(M, q; error=M.mode, kwargs...)
x = array_point(inverse_translate(M.manifold, internal_value(p), internal_value(q), conv))
x = array_point(
inverse_translate(M.manifold, internal_value(p), internal_value(q), conv),
)
is_point(M, x; error=M.mode, kwargs...)
return x
end
Expand All @@ -144,7 +152,13 @@ function inverse_translate!(
)
is_point(M, p; error=M.mode, kwargs...)
is_point(M, q; error=M.mode, kwargs...)
inverse_translate!(M.manifold, internal_value(x), internal_value(p), internal_value(q), conv)
inverse_translate!(
M.manifold,
internal_value(x),
internal_value(p),
internal_value(q),
conv,
)
is_point(M, x; error=M.mode, kwargs...)
return x
end
Expand All @@ -161,7 +175,13 @@ function translate_diff(
is_point(M, q; error=M.mode, kwargs...)
is_vector(M, q, X; error=M.mode, kwargs...)
Y = ValidationTangentVector(
translate_diff(M.manifold, internal_value(p), internal_value(q), internal_value(X), conv),
translate_diff(
M.manifold,
internal_value(p),
internal_value(q),
internal_value(X),
conv,
),
)
pq = translate(M, p, q, conv)
is_vector(M, pq, Y; error=M.mode, kwargs...)
Expand Down
Loading