Fix compat. Allow newer Aqua. Only run Aqua on repo tests. #471
Conversation
IanButterworth
changed the title
| @@ -1,6 +1,10 @@ | |||
| # This file is a part of Julia. License is MIT: https://julialang.org/license | |||
| using Test, LinearAlgebra, SparseArrays | |||
|
|
|||
| if Base.get_bool_env("SPARSEARRAYS_AQUA_TEST", false) | |||
There was a problem hiding this comment.
Might be easier to just use
| if Base.get_bool_env("SPARSEARRAYS_AQUA_TEST", false) | |
| if get(ENV, "SPARSEARRAYS_AQUA_TEST", nothing) === "true" |
since this isn't something people will configure in general (and thus not forget whether it is 1 or true).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 85.66% 85.66%
=======================================
Files 13 13
Lines 8861 8861
=======================================
Hits 7591 7591
Misses 1270 1270 ☔ View full report in Codecov by Sentry. |
|
I think it's fine to run Aqua.jl in Base Julia Buildkite CI, we just need to make sure we respect the |
|
We need to merge something. Can you make the call @DilumAluthge |
|
Let's do this for now. |
|
We can return to running Aqua.jl in Buildkite later. For now, since everything is failing on Buildkite Julia master, let's get this PR deployed. |
|
BumpStdlibs run: https://github.com/JuliaLang/BumpStdlibs.jl/actions/runs/6883759465 |
|
BumpStdlibs PR: JuliaLang/julia#52183 |
* fix compat. Allow newer Aqua * rm removed Aqua test * only run aqua stuff on repo CI (cherry picked from commit f154de2)
No description provided.