Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; run the ambiguous testgroup in Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip #472

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DilumAluthge
Copy link
Contributor

@DilumAluthge DilumAluthge commented Nov 15, 2023

Reverts much of #471

This PR introduces a framework for installing test deps during stdlib CI in a way that respects [compat] entries. We can likely use this same framework in other stdlib repos.

@DilumAluthge DilumAluthge changed the title CI: Respect [compat] entries for test-only deps when running in Bas… CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI Nov 15, 2023
@DilumAluthge DilumAluthge force-pushed the dpa/aqua-compat-buildkite branch from 76d916a to f90945d Compare November 15, 2023 22:46
@DilumAluthge DilumAluthge changed the title CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip Nov 15, 2023
@DilumAluthge DilumAluthge changed the title CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip CI: Respect [compat] entries for test-only deps when running in Base Julia's Buildkite CI; run the ambiguous testgroup in Buildkite CI; mark Aqua.test_project_toml_formatting as @test_skip Nov 15, 2023
…e Julia's Buildkite CI; run the `ambiguous` testgroup in Buildkite CI; mark `Aqua.test_project_toml_formatting` as `@test_skip`
@DilumAluthge DilumAluthge force-pushed the dpa/aqua-compat-buildkite branch from 9f12428 to 3d9eadb Compare November 16, 2023 00:12
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f154de2) 85.64% compared to head (879a806) 85.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   85.64%   85.69%   +0.04%     
==========================================
  Files          13       13              
  Lines        8861     8861              
==========================================
+ Hits         7589     7593       +4     
+ Misses       1272     1268       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ViralBShah ViralBShah requested a review from fredrikekre January 9, 2024 05:10
@ViralBShah
Copy link
Member

Anything further to be done here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants