fix: make @register_array_symbolic overload promote_symtype
#1129
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1129 +/- ##
===========================================
- Coverage 77.07% 10.12% -66.95%
===========================================
Files 32 35 +3
Lines 3533 3623 +90
===========================================
- Hits 2723 367 -2356
- Misses 810 3256 +2446 ☔ View full report in Codecov by Sentry. |
|
Looks like plenty of test failures? |
|
Yeah, didn't expect there to be. I'll look into it |
AayushSabharwal
force-pushed
the
as/register-array-promote-symtype
branch
from
0421ae5 to
b78d724
Compare
|
I have updated SparseDiffTools to use the latest ADTypes.jl, it's available in 2.19 https://github.com/JuliaDiff/SparseDiffTools.jl/releases/tag/v2.19.0 |
|
If not for PolyesterForwardDiff.jl we could even recover 1.6 compat |
| @test ndims(gg) == 2 | ||
| @test size(gg) == (8,8) | ||
| @test eltype(gg) == Real | ||
| @test symtype(unwrap(gg)) == SymMatrix{Real, 2} |
There was a problem hiding this comment.
Why is this SymMatrix{Real, 2} and the other SymMatrix{Real}?
There was a problem hiding this comment.
We can't infer ndims if it's not specified in the macrocall, since promote_symtype only gets the types of arguments to the function
| end | ||
| let | ||
| # redefine with promote_symtype | ||
| @register_array_symbolic ggg(x::AbstractVector) begin |
There was a problem hiding this comment.
It's better to use a different function so that we can re-include the file.
Close #1128