Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't rely on RAT internals in EnsembleSolution indexing #687

Merged

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

What does this fix?

@AayushSabharwal
Copy link
Member Author

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented May 6, 2024

SciMLBase downstream failing is pretty critical so I'm really trying to get it working. It's led to a bunch of stuff going undetected because CI failed before the tests that would detect it ran

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.25%. Comparing base (a0fab7a) to head (a105744).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #687      +/-   ##
==========================================
+ Coverage   31.79%   41.25%   +9.45%     
==========================================
  Files          55       55              
  Lines        4535     4543       +8     
==========================================
+ Hits         1442     1874     +432     
+ Misses       3093     2669     -424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Sparse(AutoForwardDiff()), but how that happened to get an incompatible version is a mystery right now @gdalle @Vaibhavdixit02 @avik-pal

@gdalle
Copy link
Contributor

gdalle commented May 6, 2024

I have no clue what RAT or EnsembleSolution are, or how sparse autodiff is even involved here, can someone brief me in case I'm the one who should help?

@AayushSabharwal
Copy link
Member Author

I think Chris was referring to JuliaSymbolics/Symbolics.jl#1129 actually, specifically this failure

@gdalle
Copy link
Contributor

gdalle commented May 6, 2024

I answered on the other issue ;)

@ChrisRackauckas ChrisRackauckas merged commit 5fb76df into SciML:master May 9, 2024
34 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants