Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid depending on SymbolicsNemoExt in SymbolicsGroebnerExt #1310

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Avoid depending on SymbolicsNemoExt in SymbolicsGroebnerExt #1310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions ext/SymbolicsGroebnerExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,15 +317,23 @@ function Symbolics.solve_multivar(eqs::Vector, vars::Vector{Num}; dropmultiplici
sol
end

# Helps with precompilation time
PrecompileTools.@setup_workload begin
@variables a b c x y z
simple_linear_equations = [x - y, y + 2z]
equations_intersect_sphere_line = [x^2 + y^2 + z^2 - 9, x - 2y + 3, y - z]
PrecompileTools.@compile_workload begin
symbolic_solve(simple_linear_equations, [x, y], warns=false)
symbolic_solve(equations_intersect_sphere_line, [x, y, z], warns=false)
end
end

# XXX: on 1.11, SymbolicsNemoExt isn't actually loaded during the pre-compilation of SymbolicsGroebnerExt,
# so we can't run a workload using its definitions yet. (The new restriction was added in 1.11 because
# of "AB" issues where an extension A and B would mutually expect the other to load "first")
#
# This can be re-enabled when it is possible for an extension A to explicitly declare that it depends on
# an extension B.

# # Helps with precompilation time
# PrecompileTools.@setup_workload begin
# @variables a b c x y z
# simple_linear_equations = [x - y, y + 2z]
# equations_intersect_sphere_line = [x^2 + y^2 + z^2 - 9, x - 2y + 3, y - z]
# PrecompileTools.@compile_workload begin
# symbolic_solve(simple_linear_equations, [x, y], warns=false)
# symbolic_solve(equations_intersect_sphere_line, [x, y, z], warns=false)
# end
# end

end # module
Loading