Avoid depending on SymbolicsNemoExt in SymbolicsGroebnerExt
#1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topolarity
force-pushed
the
ct/fix-1.11.1
branch
from
329a3c4 to
2cd3d15
Compare
This is no longer supposed to be allowed in 1.11, but that change was unfortunately added in the 1.11.1 patch release instead of 1.11.0 like it was intended.
topolarity
force-pushed
the
ct/fix-1.11.1
branch
from
2cd3d15 to
662d903
Compare
|
Shouldn't these be moved to |
|
Can they? I thought this workload used both Groebner and Nemo functionality |
|
These cant be moved to NemoExt, any system of polys need Groebner to get solved |
n0rbed
approved these changes
Oct 18, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1310 +/- ##
==========================================
- Coverage 30.06% 6.54% -23.53%
==========================================
Files 47 47
Lines 4576 4602 +26
==========================================
- Hits 1376 301 -1075
- Misses 3200 4301 +1101 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensions are no longer allowed to assume that their triggers load new extensions at pre-compile time in 1.11 (this was the root cause of a number of pre-compilation / loading "cycle" issues like JuliaLang/julia#55517), so
SymbolicsGroebnerExtis not allowed to use the methods implemented inSymbolicsNemoExtat precompile-time.That restriction was supposed to be enabled in 1.11.0, but it was unfortunately added in the 1.11.1 patch release.