Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PY3.13 support issues; drop PY3.8 support #1352

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ktbyers
Copy link

@ktbyers ktbyers commented Dec 16, 2024

PY3.8 is EOL.

Used vendored version of telnetlib inside of Netmiko; alternative is to completely drop telnet support (of find some alternatively maintained telnet library).

@ktbyers
Copy link
Author

ktbyers commented Dec 16, 2024

Another option is to just gracefully catch the import telnetlib failure such that it doesn't cause the Device import to fail.

Basically, create a deprecation warning and gracefully catch the import telnetlib failure. In this way, people using PY3.9 - PY3.12 could keep using telnetlib and PY3.13 would work for its main uses. telnet function would cease working in PY3.13 as it would be deprecated by PyEZ.

@a-detiste
Copy link

https://github.com/youknowone/python-deadlib provides telnetlib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants