Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PY3.13 support issues; drop PY3.8 support #1352

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −5
Open

Fix PY3.13 support issues; drop PY3.8 support #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5501079
Convert to Netmiko's versioned telnetlib
ktbyers Dec 16, 2024
78a1ed1
Drop PY3.8 support; Add PY3.13 support
ktbyers Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pylint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
matrix:
os: [ ubuntu-latest, windows-latest ]
python-version: [ 3.9, '3.10', 3.11, 3.12 ]
python-version: [ 3.9, '3.10', 3.11, 3.12, 3.13 ]
exclude:
- os: windows-latest
python-version: 3.9
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ _Junos PyEZ_ is designed to provide the same capabilities as a user would have o

## PIP

Installation requires Python >=3.8 and associated `pip` tool
Installation requires Python >=3.9 and associated `pip` tool

pip install junos-eznc

Expand Down
2 changes: 1 addition & 1 deletion lib/jnpr/junos/transport/tty_telnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from time import sleep
import telnetlib
from netmiko._telnetlib import telnetlib
import logging
import sys
import six
Expand Down
2 changes: 2 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ scp>=0.7.0
jinja2>=2.7.1
PyYAML>=5.1
paramiko>=3.5.0
# needed to support telnetlib (i.e. Netmiko vendored telnetlib internally)
netmiko>=4.4.0
six
pyserial
yamlordereddictloader
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"jnpr.junos.cfgro": ["*.yml"],
"jnpr.junos.resources": ["*.yml"],
},
python_requires=">=3.8",
python_requires=">=3.9",
install_requires=install_reqs,
classifiers=[
"Development Status :: 5 - Production/Stable",
Expand All @@ -37,11 +37,11 @@
"License :: OSI Approved :: Apache Software License",
"Operating System :: OS Independent",
"Programming Language :: Python",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Software Development :: Libraries",
"Topic :: Software Development :: Libraries :: Application Frameworks",
"Topic :: Software Development :: Libraries :: Python Modules",
Expand Down