exclusively using pipenv #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically reverts 7302ae8 includes somes build speed improvements with order
makrsmark
force-pushed
the
docker-pipenv
branch
from
29d78f2 to
c0c18b3
Compare
makrsmark
commented
Jan 3, 2023
makrsmark
commented
Jan 3, 2023
| RUN pip3 install --upgrade pip && \ | ||
| pip3 install -U --no-cache-dir -r ./requirements.txt | ||
| # Install dependencies | ||
| COPY Pipfile* . |
There was a problem hiding this comment.
doing a pipenv install with only the pipfile ensures a docker build doesn't do a full install every time there's a code change
removes unneded files from docker image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
essentially reverts 7302ae8
including some build speed changes