Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclusively using pipenv #111

Merged
merged 2 commits into from
May 12, 2023
Merged

exclusively using pipenv #111

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0c18b3
exclusively using pipenv
makrsmark Dec 24, 2022
06b74ac
cleaning apt cache
makrsmark Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 16 additions & 28 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,25 @@
FROM python:3

WORKDIR /plane-notify
USER root

COPY . .
# Added needed folder for plane-notify process
RUN mkdir /home/plane-notify

RUN set -ex && \
apt-get update -qq && \
apt-get -y -qq install --no-install-recommends \
ca-certificates \
gnupg && \
curl -sSL https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - && \
echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" > /etc/apt/sources.list.d/google.list && \
apt-get -y -qq update \
&& apt-get -y -qq install --no-install-recommends \
bash \
curl \
google-chrome-stable \
python3 \
python3-dev \
python3-pip \
python3-setuptools \
python3-wheel \
&& rm -rf \
/var/lib/apt/lists/* \
/var/cache/apt/archives
# Set the Chrome repo.
RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
&& echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list

# Install Chrome.
RUN apt-get update && apt-get -y install --no-install-recommends \
google-chrome-stable \
python3-dev

# Add pipenv
RUN pip install pipenv

RUN pip3 install --upgrade pip && \
pip3 install -U --no-cache-dir -r ./requirements.txt
# Install dependencies
COPY Pipfile* .
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing a pipenv install with only the pipfile ensures a docker build doesn't do a full install every time there's a code change

RUN pipenv install

# Added needed folder for plane-notify process
RUN mkdir -p /home/plane-notify

CMD python3 /plane-notify/__main__.py
COPY . .
CMD pipenv run python /plane-notify/__main__.py
22 changes: 0 additions & 22 deletions requirements.txt
View file
Open in desktop

This file was deleted.