-
Notifications
You must be signed in to change notification settings - Fork 30
Have created loader items inherit the parent context #12
base: master
Are you sure you want to change the base?
Conversation
Hi Znurre, thank you for your contributions. We'll take a look and get back to you by the end of the month. Kind regards, |
Hi Znurre, before we can accept your contributions to DeclarativeWidgets we will need a signed Copyright Assignment form from you, and if you are employed we will also need your employer to sign the Disclaimer part of the agreement. The form is attached to this comment, and includes instructions detailing what you need to do. Kind regards, |
Hi Nathan, I've sent a signed Copyright Assignment form to the e-mail address specified in the form 8 days ago, but without any reply so far. Best regards, |
Hi Lova, I'll chase it up, thanks for letting me know. Kind regards, |
Hi Lova, we haven't been able to find the e-mail you sent. Could you please resend it to [email protected] Kind regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Having support for |
I am not sure why I never got around to merging this. To be honest, I thought I did, but I guess not. If time permits, I will have a look at changing this PR to target another branch of my repo and prepare that for submission as per the scope of the original PR. |
The current behavior for LoaderWidget seems to differ from that of Loader in that components loaded by Loader will have access to the parent context's properties while items loaded by LoaderWidget will only have access to the root context's properties.
This change attempts to unify the behavior and have LoaderWidget behave the same way as Loader.