Port to CMake #31
Merged
Port to CMake #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Examples works and tests pass. install rules to be created in a follow-up, only then README updated to promote CMake.
Window when shown wasn't honouring its preferred height and was slightly bigger. Seems window manager specific since with offscreen QPA it works, only with X11 it doesn't. It's a bug either in Qt or in the test code, the declarative widget layouting is fine and passing all tests that are related to the grid layout. Added XFAILs for QTBUG-66747
It's flaky depending on window manager. Needs to be investigated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.