Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep spaces and newline characters when sanitizing the commit message #88

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ll-nick
Copy link
Collaborator

@ll-nick ll-nick commented Nov 21, 2024

To reduce the already unlikely chance of accidentally setting a version bump #flag in the sanitized version of the PR description even further, we now keep whitespaces and newline characters.

#patch

@ll-nick ll-nick requested a review from orzechow November 21, 2024 15:58
@ll-nick ll-nick self-assigned this Nov 21, 2024
Copy link
Member

@orzechow orzechow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😁

Weird syntax for the newline, but 🤷‍♂️

@ll-nick
Copy link
Collaborator Author

ll-nick commented Nov 22, 2024

Yeah, I really don't like that either. It was also hard to find that this syntax actually exists and works. I still thought that this is nicer than using another tool such as tr when bash has this pattern replacement built-in.

@ll-nick ll-nick merged commit 4bb8da6 into main Nov 22, 2024
1 check passed
@ll-nick ll-nick deleted the keep_whitespace_when_computing_version branch November 22, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants