-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #37356 - Allow turning automatic content count updates off #11014
Conversation
7854239
to
3d4f099
Compare
Rebased for pipeline.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, packit/PRT at the companion PR passed: SatelliteQE/robottelo#15371 (comment)
I wonder, why a async task can slow down other tasks. Instead of adding a new setting and make this feature configuruable, wouldn't it be better to think about how this feature can be improved? E.g.: |
This seems to happen for users with slow master -> proxy connections and the API call to pulp takes a long time. This is a band-aid for such users to turn it off and run this manually when they need to. We have some improvements to this in the pipeline which include making the task granular and only run on contents that have actually changed but that will be follow up PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here and thanks for your patience.
Code LGTM other than the alignment nit.
I thought about asking for a test, but looking at test/actions/katello/capsule_content_test.rb and then app/lib/actions/katello/capsule_content/update_content_counts.rb there doesn't seem enough need
3d4f099
to
938d092
Compare
…ello#11014) (cherry picked from commit 98dfce0)
) (cherry picked from commit 98dfce0)
[PR] Fixes #37356 - Allow turning automatic content count updates off (Katello#11014) See merge request orcharhino/foreman_components/katello!169
What are the changes introduced in this pull request?
Add a setting "automatic_content_count_updates" to control automatic invocation of Update content count task on proxies upon successful syncs.
Considerations taken when implementing this change?
The Update content counts action is triggered asynchronously upon a successful sync on a proxy.
This task can be a long running task for large proxies on a slow connection and this can cause slowness in syncs in the queue.
What are the testing steps for this pull request?