Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test case for automatic content counts update toggling #15371

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Add test case for automatic content counts update toggling #15371

merged 3 commits into from
Jun 19, 2024

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Jun 7, 2024

Problem Statement

New setting to disable automatic content count update has been introduced and we should test how it works, since it's customer facing.

Solution

This PR adds just such a case.

Related Issues

https://bugzilla.redhat.com/show_bug.cgi?id=2284027
needs Katello/katello#11014

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_automatic_content_counts_update_toggle
Katello:
    katello: 11014

@vsedmik vsedmik added the No-CherryPick PR doesnt need CherryPick to previous branches label Jun 7, 2024
@vsedmik vsedmik self-assigned this Jun 7, 2024
@vsedmik vsedmik requested a review from a team as a code owner June 7, 2024 11:06
@vsedmik
Copy link
Contributor Author

vsedmik commented Jun 7, 2024 

trigger: test-robottelo
pytest: tests/foreman/api/test_capsulecontent.py -k test_automatic_content_counts_update_toggle
Katello:
    katello: 11014

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 7320
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_capsulecontent.py -k test_automatic_content_counts_update_toggle --external-logging
Test Result : ========== 1 passed, 23 deselected, 37 warnings in 2925.00s (0:48:45) ==========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 7, 2024
@vsedmik vsedmik mentioned this pull request Jun 7, 2024
Merged
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Jun 7, 2024
pondrejk
pondrejk requested changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@pondrejk pondrejk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

tests/foreman/api/test_capsulecontent.py Outdated
@@ -1651,6 +1665,112 @@ def test_positive_content_counts_blank_update(
counts is None or len(counts['content_view_versions']) == 0
), f"No content counts expected, but got:\n{counts['content_view_versions']}."

@pytest.mark.skip_if_open('SAT-25542')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be turned to :BlockedBy or :Verifies tag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:BlockedBy:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:Verifies: is primarily used to map a feature to test(s). :BlockedBy: for skipping a test because of some bugs.

Copy link
Contributor Author

@vsedmik vsedmik Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turned into :BlockedBy:.

@jameerpathan111 jameerpathan111 self-requested a review June 12, 2024 09:11
jameerpathan111
jameerpathan111 reviewed Jun 12, 2024
View reviewed changes
tests/foreman/api/test_capsulecontent.py

:CaseImportance: Medium

:BZ: 2284027
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:BZ: 2284027
:BZ: 2284027
:Verifies: SAT-25503

Can we add Verifies field too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameerpathan111 I think we should not since it's not a feature? (It's a BZ coverage only)
As you say here #15371 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's usage is not limited to feature coverage I'd say. If it's covering a BZ scenario then it counts under Verifies too and we shouldn't use :BZ: anymore anyway. @JacobCallahan correct me if I'm wrong.

tests/foreman/api/test_capsulecontent.py Outdated
@@ -1651,6 +1665,112 @@ def test_positive_content_counts_blank_update(
counts is None or len(counts['content_view_versions']) == 0
), f"No content counts expected, but got:\n{counts['content_view_versions']}."

@pytest.mark.skip_if_open('SAT-25542')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:BlockedBy:

tests/foreman/api/test_capsulecontent.py Outdated
@@ -1651,6 +1665,112 @@ def test_positive_content_counts_blank_update(
counts is None or len(counts['content_view_versions']) == 0
), f"No content counts expected, but got:\n{counts['content_view_versions']}."

@pytest.mark.skip_if_open('SAT-25542')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:Verifies: is primarily used to map a feature to test(s). :BlockedBy: for skipping a test because of some bugs.

damoore044
damoore044 approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@damoore044 damoore044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack nice work! pending the other comments, some are non-blocking

vijaysawant
vijaysawant approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@vijaysawant vijaysawant merged commit d00f5bb into SatelliteQE:master Jun 19, 2024
8 checks passed
vsedmik added a commit to vsedmik/robottelo that referenced this pull request Jul 23, 2024
@vsedmik
Add test case for automatic content counts update toggling (Satellite…
d393d41 
…QE#15371)

* Add test case for automatic content counts update toggling

* Uncomment skip_if_open so we can merge

* Address comments
@vsedmik vsedmik mentioned this pull request Jul 23, 2024
Merged
pondrejk pushed a commit that referenced this pull request Jul 24, 2024
@vsedmik
[6.15.z] Add test case for automatic content counts update toggling (#…
a2921a8 
…15732)

Add test case for automatic content counts update toggling (#15371)

* Add test case for automatic content counts update toggling

* Uncomment skip_if_open so we can merge

* Address comments
jyejare pushed a commit to jyejare/robottelo that referenced this pull request Oct 19, 2024
@vsedmik @jyejare
Add test case for automatic content counts update toggling (Satellite…
4342283 
…QE#15371)

* Add test case for automatic content counts update toggling

* Uncomment skip_if_open so we can merge

* Address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damoore044 damoore044 damoore044 approved these changes

@synkd synkd synkd approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@jameerpathan111 jameerpathan111 jameerpathan111 approved these changes

@pondrejk pondrejk pondrejk approved these changes

Assignees

@vsedmik vsedmik

Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vsedmik @Satellite-QE @pondrejk @jameerpathan111 @vijaysawant @synkd @damoore044