Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs #441

Merged
merged 21 commits into from
Nov 21, 2024
Merged

Improve docs #441

merged 21 commits into from
Nov 21, 2024

Conversation

DimaMolod
Copy link
Collaborator

No description provided.

@DimaMolod
Copy link
Collaborator Author

TODO: #434 #433 #418

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@jkosinski jkosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I added some minor suggestions

README.md Show resolved Hide resolved
--profile slurm_noSidecar \
--rerun-incomplete \
--rerun-triggers mtime \
--latency-wait 30 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the command cannot end with , missing line with -n?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have:

    --profile slurm_noSidecar \
    --rerun-incomplete \
    --rerun-triggers mtime \
    --latency-wait 30 \

but should be either

    --profile slurm_noSidecar \
    --rerun-incomplete \
    --rerun-triggers mtime \
    --latency-wait 30

or

    --profile slurm_noSidecar \
    --rerun-incomplete \
    --rerun-triggers mtime \
    --latency-wait 30 \
    -n

README.md Show resolved Hide resolved
Copy link
Collaborator

@jkosinski jkosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some responses and clarfications.

jkosinski and others added 4 commits November 21, 2024 12:14
Anaconda3 is no longer available and cuda modules no longer necessary
Refine create_individual_features.py SLURM example
@DimaMolod DimaMolod merged commit 802079e into main Nov 21, 2024
6 checks passed
@DimaMolod DimaMolod deleted the improve_docs branch November 21, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants