-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grafana kubebuilder plugin #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Couple of questions:
- Do we intend to define dashboards like this in each sub component and pull them into the kuadrant operator grafana setup?
- Is there any way we can pull in grafana and prometheus setup from somewhere (kuadrant operator?) and optionally add it to the local-setup kustomization so we can test this locally without needing to set that up manually or use quickstart?
- Any recommended docs on how to work with any of this?
+1
I think we should have these in each kube-builder based component
|
From the slack chat https://book.kubebuilder.io/plugins/grafana-v1-alpha.html?highlight=grafana#grafana-plugin-grafanav1-alpha |
Easiest method I've found is https://github.com/prometheus-operator/kube-prometheus/blob/main/kustomization.yaml 1 issue is the timing of CRDs being ready, and CRs being created. |
@david-martin one minor change I would suggest is the name of the service monitor. It is very generic right now and would prob clash with others. Ok to set is as part of this PR before merge? IE dns-operator-metrics-monitor ? |
Once this merges I want to pull it into the eng environment also |
e35c82a
to
9cd5a73
Compare
@maleck13 changed. |
The changes in this PR are the result of running
kubebuilder edit --plugins grafana.kubebuilder.io/v1-alpha
Verified locally via the kuadrant-operator:
KUADRANT_REF=main
kubectl --context $KUBECTL_CONTEXT -n monitoring port-forward svc/grafana 3000:3000
looks like this:
runtime metrics
resource metrics