fix: Namespaced deployment overlay generation #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove dnshealthcheckprobes CRD for namespaced deployments * Add crd to cluster kustomization * Improve dns provider generation, avoid calling a base that requires a local file. Signed-off-by: Michael Nairn <[email protected]>
Signed-off-by: Michael Nairn <[email protected]>
Test was incorrectly checking for "GEO-" in the aws provider specific endpoint values. Signed-off-by: Michael Nairn <[email protected]>
mikenairn
force-pushed
the
fix_overlay_gen
branch
from
a0396b0 to
5b3a166
Compare
|
github action sounds good |
maleck13
reviewed
Nov 8, 2024
| @@ -8,3 +8,9 @@ patches: | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| name: dnsrecords.kuadrant.io | |||
| - patch: |- | |||
There was a problem hiding this comment.
Not getting why this is needed?
There was a problem hiding this comment.
The ../../deploy/local kustomization which this is modifying adds the crds which prevents you from using it multiple times in an overlay. When we install multiple instances of the dns operator we can use this kustomization which removes the CRDs multiple times for each namespace we want to install into, and install the crds separately once.
maleck13
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Namespaced deployment overlay generation
bump kustomize version v5.5.0
fix: Multi record test
Test was incorrectly checking for "GEO-" in the aws provider specific endpoint values.
Note: This test is executed on the e2e but only with 1 cluster/deployment so it never uses the second geo, you can re-create the issue by running:
We should probably consider adding a GitHub action that executes it this way.