Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove health checker #54

Merged
merged 3 commits into from
Mar 11, 2024
Merged

remove health checker #54

merged 3 commits into from
Mar 11, 2024

Conversation

maleck13
Copy link
Collaborator

@maleck13 maleck13 commented Mar 11, 2024

closes #45
closes #25

PROJECT Show resolved Hide resolved
PROJECT Outdated Show resolved Hide resolved
@mikenairn
Copy link
Member

@maleck13 Can you run go mod tidy, it should remove the gateway-api direct dependency.

@mikenairn
Copy link
Member

@maleck13 You also need to remove https://github.com/Kuadrant/dns-operator/blob/main/config/manifests/bases/dns-operator.clusterserviceversion.yaml#L18-L23. For some reason operator-sdk generate kustomize manifests -q doesn't remove it, but if you empty the array and re-run it will be as expected 🤷‍♂️ .

Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maleck13
Copy link
Collaborator Author

updated @mikenairn

@mikenairn mikenairn merged commit 7bcacff into main Mar 11, 2024
8 checks passed
@mikenairn mikenairn deleted the gh-45 branch March 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove provider agnostic health check monitor DNS Operator uses excessive CPU
2 participants