Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove health checker #54

Merged
merged 3 commits into from
Mar 11, 2024
Merged

remove health checker #54

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd1a31a
remove health checker
maleck13 Mar 11, 2024
8e2feda
update bundle
maleck13 Mar 11, 2024
a8b5246
updates post review
maleck13 Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions PROJECT
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,3 @@ resources:
kind: DNSRecord
path: github.com/kuadrant/dns-operator/api/v1alpha1
version: v1alpha1
- api:
crdVersion: v1
namespaced: true
controller: true
domain: kuadrant.io
kind: DNSHealthCheckProbe
path: github.com/kuadrant/dns-operator/api/v1alpha1
version: v1alpha1
version: "3"
mikenairn marked this conversation as resolved.
Show resolved Hide resolved
88 changes: 0 additions & 88 deletions api/v1alpha1/dnshealthcheckprobe_types.go
View file
Open in desktop

This file was deleted.

56 changes: 0 additions & 56 deletions api/v1alpha1/health_types.go
View file
Open in desktop

This file was deleted.

160 changes: 0 additions & 160 deletions api/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 1 addition & 24 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ package main
import (
"flag"
"os"
"time"

"k8s.io/apimachinery/pkg/runtime"
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
Expand All @@ -33,7 +32,6 @@ import (

"github.com/kuadrant/dns-operator/api/v1alpha1"
"github.com/kuadrant/dns-operator/internal/controller"
"github.com/kuadrant/dns-operator/internal/health"
"github.com/kuadrant/dns-operator/internal/provider"
_ "github.com/kuadrant/dns-operator/internal/provider/aws"
_ "github.com/kuadrant/dns-operator/internal/provider/google"
Expand Down Expand Up @@ -84,19 +82,6 @@ func main() {

providerFactory := provider.NewFactory(mgr.GetClient())

healthMonitor := health.NewMonitor()
healthCheckQueue := health.NewRequestQueue(time.Second * 5)

if err := mgr.Add(healthMonitor); err != nil {
setupLog.Error(err, "unable to start health monitor")
os.Exit(1)
}

if err := mgr.Add(healthCheckQueue); err != nil {
setupLog.Error(err, "unable to start health check queue")
os.Exit(1)
}

if err = (&controller.ManagedZoneReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
Expand All @@ -113,15 +98,7 @@ func main() {
setupLog.Error(err, "unable to create controller", "controller", "DNSRecord")
os.Exit(1)
}
if err = (&controller.DNSHealthCheckProbeReconciler{
Client: mgr.GetClient(),
Scheme: mgr.GetScheme(),
HealthMonitor: healthMonitor,
Queue: healthCheckQueue,
}).SetupWithManager(mgr); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "DNSHealthCheckProbe")
os.Exit(1)
}

//+kubebuilder:scaffold:builder

if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
Expand Down
Loading
Loading