Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reshape method #1760

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
726da15
reshape methods
artv3 Nov 5, 2024
119cc95
Merge branch 'develop' into artv3/reshape
artv3 Dec 12, 2024
e105bae
Merge branch 'develop' into artv3/reshape
artv3 Dec 23, 2024
78d32b3
add alias for view type
artv3 Dec 23, 2024
9807f31
compile time reverse array
artv3 Dec 23, 2024
28e714d
review reshape example
artv3 Dec 23, 2024
fc1f6a8
clean up pass
artv3 Dec 23, 2024
4d05ea5
clean up reshape example
artv3 Dec 23, 2024
b0a836a
push up version that takes index_seq
artv3 Dec 23, 2024
a1a254d
fix bug with custom layout
artv3 Dec 26, 2024
a691f40
clean up based on pr comments
artv3 Dec 26, 2024
cf3ff8c
Update include/RAJA/util/View.hpp
artv3 Dec 26, 2024
7ddbdb1
fix inside function call
artv3 Dec 26, 2024
c33e1d1
merge develop + fix conflict
artv3 Jan 16, 2025
d09d6e0
make style
artv3 Jan 17, 2025
a9a9119
Merge branch 'develop' into artv3/reshape
rhornung67 Feb 20, 2025
fb46fec
Merge branch 'develop' into artv3/reshape
artv3 Mar 5, 2025
c2afb99
add docs
artv3 Mar 5, 2025
94cf153
clean up pass
artv3 Mar 5, 2025
a1534f3
fix spelling
artv3 Mar 5, 2025
41c4b0c
PR comments
artv3 Mar 5, 2025
0b98518
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
a317bd5
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
6dbbc9c
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
5f39b64
Update docs/sphinx/user_guide/feature/view.rst
artv3 Mar 5, 2025
928bd1d
remove unused code
artv3 Mar 5, 2025
163f91c
clean up pass
artv3 Mar 5, 2025
1d3fd1d
clean up pass
artv3 Mar 5, 2025
d316505
another pass
artv3 Mar 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
# SPDX-License-Identifier: (BSD-3-Clause)
###############################################################################

raja_add_executable(
NAME reshape
SOURCES reshape.cpp)

raja_add_executable(
NAME tut_launch_basic
SOURCES tut_launch_basic.cpp)
Expand Down
163 changes: 163 additions & 0 deletions examples/reshape.cpp
Original file line number Diff line number Diff line change
@@ -0,0 +1,163 @@
//~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~//
// Copyright (c) 2016-24, Lawrence Livermore National Security, LLC
// and RAJA project contributors. See the RAJA/LICENSE file for details.
//
// SPDX-License-Identifier: (BSD-3-Clause)
//~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~//

#include <cmath>
#include <cstdlib>
#include <cstring>
#include <iostream>

#include "RAJA/RAJA.hpp"
#include "RAJA/util/Timer.hpp"


#include "memoryManager.hpp"

/*
* RAJA Reshape method
*
* This example will intialize array using
* the RAJA Reshape method. The Reshape
* method offers right and left most unit
* stride.
*
*/

/*
* Define number of threads in a GPU thread block
*/
#if defined(RAJA_ENABLE_CUDA)
constexpr int CUDA_BLOCK_SIZE = 256;
#endif

#if defined(RAJA_ENABLE_HIP)
constexpr int HIP_BLOCK_SIZE = 256;
#endif

//
//Function for checking results
//
void checkResult(int *ptr, int K, int N, int M);

int main(int RAJA_UNUSED_ARG(argc), char **RAJA_UNUSED_ARG(argv[]))
{

std::cout << "\n\nRAJA reshape method example....\n"<< std::endl;

const int K = 3;
const int N = 1;
const int M = 2;

// Allocate memory for pointer
int *Rptr = memoryManager::allocate<int>(K * N * M);
int *Lptr = memoryManager::allocate<int>(K * N * M);
int *Cptr = memoryManager::allocate<int>(K * N * M);

//----------------------------------------------------------------------------//
//
// Initialize memory using right most unit stride
//
//----------------------------------------------------------------------------//
std::cout << "\n\nInitialize array with right most indexing...\n";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these implementations are much easier to understand if your intent is just to show the mechanics of View reshaping. 👍

auto Rview = RAJA::Reshape<RAJA::layout_right>::get(Rptr, K, N, M);

for(int k = 0; k < K; ++k) {
for(int n = 0; n < N; ++n) {
for(int m = 0; m < M; ++m) {
const int idx = m + M * (n + N * k);
Rview(k,n,m) = idx;
}
}
}

checkResult(Rptr, K, N, M);


//----------------------------------------------------------------------------//
//
// Initialize memory using left most unit stride
//
//----------------------------------------------------------------------------//
std::cout << "\n\nInitialize array with left most indexing...\n";

auto Lview = RAJA::Reshape<RAJA::layout_left>::get(Lptr, K, N, M);

//Note the loop ordering has change from above
for(int m = 0; m < M; ++m) {
for(int n = 0; n < N; ++n) {
for(int k = 0; k < K; ++k) {

const int idx = k + K * (n + N * m);
Lview(k,n,m) = idx;
}
}
}

checkResult(Lptr, K, N, M);


//----------------------------------------------------------------------------//
//
// Initialize memory using custom ordering, longest stride starts at the left,
// right most is assumed to have unit stride.
//
//----------------------------------------------------------------------------//
std::cout << "\n\nInitialize array with custom indexing...\n";

using custom_seq = std::index_sequence<2U,0U,1U>;


auto Cview = RAJA::Reshape<custom_seq>::get(Cptr, K, N, M);

//Note the loop ordering has change from above
for(int m = 0; m < M; ++m) {
for(int k = 0; k < K; ++k) {
for(int n = 0; n < N; ++n) {

const int idx = n + N * (k + K * m);
Cview(k,n,m) = idx;
}
}
}

checkResult(Cptr, K, N, M);


//
// Clean up.
//
memoryManager::deallocate(Rptr);
memoryManager::deallocate(Lptr);

std::cout << "\n DONE!...\n";
return 0;
}

//
// check result
//
void checkResult(int *ptr, int K, int N, int M)
{

bool status = true;

for(int k = 0; k < K; ++k) {
for(int n = 0; n < N; ++n) {
for(int m = 0; m < M; ++m) {
const int idx = m + M * (n + N * k);
if (std::abs(ptr[idx] - idx) > 0) {
status = false;
}
}
}
}

if ( status ) {
std::cout << "\tresult -- PASS\n";
} else {
std::cout << "\tresult -- FAIL\n";
}
}
83 changes: 80 additions & 3 deletions include/RAJA/util/View.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#define RAJA_VIEW_HPP

#include <type_traits>
#include <array>

#include "RAJA/config.hpp"

Expand Down Expand Up @@ -81,14 +82,14 @@ RAJA_INLINE View<ValueType, IndexLayout<n_dims, IndexType, IndexTypes...> > make
// select certain indices from a tuple, given a curated index sequence
// returns linear index of layout(ar...)
template <typename Lay, typename Tup, camp::idx_t... Idxs>
RAJA_HOST_DEVICE RAJA_INLINE
RAJA_HOST_DEVICE RAJA_INLINE
auto selecttuple( Lay lyout, Tup&& tup, camp::idx_seq<Idxs...> ) ->
decltype(
lyout(
camp::get<Idxs>(std::forward<Tup>(tup))...
)
)
{
{
return lyout(
camp::get<Idxs>(std::forward<Tup>(tup))...
);
Expand Down Expand Up @@ -234,7 +235,7 @@ struct MultiView {
{
RAJA_ABORT_OR_THROW( "Negative index while accessing array of pointers.\n" );
}

auto idx = stripIndexType( removenth<LayoutType, P2Pidx>( layout, camp::forward_as_tuple( ar... ) ) );
return data[pidx][idx];
}
Expand Down Expand Up @@ -296,6 +297,82 @@ RAJA_INLINE AtomicViewWrapper<ViewType, AtomicPolicy> make_atomic_view(
return RAJA::AtomicViewWrapper<ViewType, AtomicPolicy>(view);
}

struct layout_left{};
struct layout_right{};

template<typename LAYOUT>
struct Reshape;

template<typename LAYOUT>
struct Reshape;

template<typename T>
constexpr auto get_last_index(T last)
{
return last;
}

template<typename T, typename... Args>
constexpr auto get_last_index(T , Args... args)
{
return get_last_index(args...);
}

template<std::size_t...Is>
struct Reshape<std::index_sequence<Is...>>
{
template<typename T, typename...Ts>
static auto get(T *ptr, Ts... s)
{
constexpr int N = sizeof...(Ts);
std::array<RAJA::idx_t, N> extent{s...};

auto custom_layout =
RAJA::make_permuted_layout(extent, std::array<RAJA::idx_t, N>{Is...});

constexpr auto unit_stride = get_last_index(Is...);

return RAJA::View<T, RAJA::Layout<N, RAJA::Index_type, unit_stride>>
(ptr, custom_layout);
}
};

template<>
struct Reshape<layout_right>
{
template<typename T, typename...Ts>
static auto get(T *ptr, Ts... s)
{
constexpr int N = sizeof...(Ts);
using view_t = RAJA::View<T, RAJA::Layout<N, RAJA::Index_type, N-1>>;

return view_t(ptr, s...);
}
};

template<std::size_t... Is>
constexpr std::array<RAJA::idx_t, sizeof...(Is)> make_reverse_array(std::index_sequence<Is...>) {
return std::array<RAJA::idx_t, sizeof...(Is)>{sizeof...(Is) - 1U - Is ...};
}

template<>
struct Reshape<layout_left>
{
template<typename T, typename...Ts>
static auto get(T *ptr, Ts... s)
{
constexpr int N = sizeof...(Ts);

std::array<RAJA::idx_t, N> extent{s...};

constexpr auto reverse_array = make_reverse_array(std::make_index_sequence<N>{});

auto reverse_layout = RAJA::make_permuted_layout(extent, reverse_array);

return RAJA::View<T, RAJA::Layout<N, RAJA::Index_type, 0U>>(ptr, reverse_layout);
}

};

} // namespace RAJA

Expand Down
Loading