Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test util funcs #336

Merged
merged 2 commits into from
Sep 11, 2024
Merged

chore: test util funcs #336

merged 2 commits into from
Sep 11, 2024

Conversation

estensen
Copy link
Contributor

@estensen estensen commented Sep 9, 2024

Test coverage is pretty low. First stab at improving it.

Copy link
Collaborator

@samlaf samlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @estensen is this ready for review or were you planning on doing more work here?

@shrimalmadhur wdyt about breaking up this utils dir into more useful named modules (like utils/url_validation or utils/validation)? Also potentially moving this into internal/ to make sure other people don't rely on these functions, such that we can keep refactoring them and moving them around. Unless the CLI is using them?

@shrimalmadhur
Copy link
Collaborator

LGTM. @estensen is this ready for review or were you planning on doing more work here?

@shrimalmadhur wdyt about breaking up this utils dir into more useful named modules (like utils/url_validation or utils/validation)? Also potentially moving this into internal/ to make sure other people don't rely on these functions, such that we can keep refactoring them and moving them around. Unless the CLI is using them?

Yes. I think that makes sense. I think CLI should make it's own utils and not rely on sdk for internal utilities. I have changed some already but if I finding anything breaking I will change it in CLI. so ya let's move internal utils to internal and break them down.

@estensen
Copy link
Contributor Author

LGTM. @estensen is this ready for review or were you planning on doing more work here?

Trying to keep diffs small, so this is it for now. Was planning on continuing to have at least some tests for all functions here to get better test coverage.

@samlaf samlaf merged commit 24fa758 into Layr-Labs:dev Sep 11, 2024
4 checks passed
@estensen estensen deleted the utils branch September 11, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants