chore: test more utils funcs #340
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estensen
commented
Sep 18, 2024
| @@ -105,6 +105,7 @@ func EcdsaPrivateKeyToAddress(privateKey *ecdsa.PrivateKey) (gethcommon.Address, | |||
| return crypto.PubkeyToAddress(*publicKeyECDSA), nil | |||
| } | |||
|
|
|||
| // RoundUpDivideBig divides two positive big.Int numbers and rounds up the result. | |||
There was a problem hiding this comment.
Not sure what this is used for, but it currently doesn't handle negative numbers
estensen
commented
Sep 18, 2024
| return http.ErrUseLastResponse | ||
| }, | ||
| Timeout: 3 * time.Second, | ||
| func ReadPublicURL(url string, httpClient *http.Client) ([]byte, error) { |
There was a problem hiding this comment.
Had to change the signature to make it possible to mock. IMO we shouldn't do real HTTP reqs from tests.
estensen
commented
Sep 18, 2024
Comment on lines
+95
to
+114
| { | ||
| name: "Valid YAML", | ||
| yamlContent: ` | ||
| name: John Doe | ||
| age: 30 | ||
| `, | ||
| expected: Config{Name: "John Doe", Age: 30}, | ||
| }, | ||
| { | ||
| name: "Missing fields", | ||
| yamlContent: ` | ||
| name: Alice | ||
| `, | ||
| expected: Config{Name: "Alice", Age: 0}, | ||
| }, | ||
| { | ||
| name: "Empty YAML", | ||
| yamlContent: ``, | ||
| expected: Config{}, | ||
| }, |
There was a problem hiding this comment.
Not able to test with invalid values here or for TestReadJsonConfig since it panics. Can rewrite to return an error instead of panic so this can be tested. Consider using recover, but log.Fatal creates an unrecoverable panic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #336