-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: test more utils funcs #340
Open
estensen
wants to merge
2
commits into
Layr-Labs:dev
Choose a base branch
from
estensen:utils2
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
chore: test more utils funcs
- Loading branch information
commit 2a495a8cb93c8013ecca30e6a96694635b407d7b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -105,6 +105,7 @@ func EcdsaPrivateKeyToAddress(privateKey *ecdsa.PrivateKey) (gethcommon.Address, | |
return crypto.PubkeyToAddress(*publicKeyECDSA), nil | ||
} | ||
|
||
// RoundUpDivideBig divides two positive big.Int numbers and rounds up the result. | ||
func RoundUpDivideBig(a, b *big.Int) *big.Int { | ||
one := new(big.Int).SetUint64(1) | ||
res := new(big.Int) | ||
|
@@ -118,14 +119,13 @@ func IsValidEthereumAddress(address string) bool { | |
return ethAddrPattern.MatchString(address) | ||
} | ||
|
||
func ReadPublicURL(url string) ([]byte, error) { | ||
// allow no redirects | ||
httpClient := http.Client{ | ||
CheckRedirect: func(req *http.Request, via []*http.Request) error { | ||
return http.ErrUseLastResponse | ||
}, | ||
Timeout: 3 * time.Second, | ||
func ReadPublicURL(url string, httpClient *http.Client) ([]byte, error) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Had to change the signature to make it possible to mock. IMO we shouldn't do real HTTP reqs from tests. |
||
// Allow no redirects | ||
httpClient.CheckRedirect = func(req *http.Request, via []*http.Request) error { | ||
return http.ErrUseLastResponse | ||
} | ||
httpClient.Timeout = 3 * time.Second | ||
|
||
resp, err := httpClient.Get(url) | ||
if err != nil { | ||
return []byte{}, err | ||
|
@@ -213,7 +213,7 @@ func CheckIfUrlIsValid(rawUrl string) error { | |
return nil | ||
} | ||
|
||
func IsImageURL(urlString string) error { | ||
func IsImageURL(urlString string, httpClient *http.Client) error { | ||
// Parse the URL | ||
parsedURL, err := url.Parse(urlString) | ||
if err != nil { | ||
|
@@ -229,7 +229,7 @@ func IsImageURL(urlString string) error { | |
// Check if the extension is in the list of image extensions | ||
for _, imgExt := range ImageExtensions { | ||
if strings.EqualFold(extension, imgExt) { | ||
imageBytes, err := ReadPublicURL(urlString) | ||
imageBytes, err := ReadPublicURL(urlString, httpClient) | ||
if err != nil { | ||
return err | ||
} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what this is used for, but it currently doesn't handle negative numbers