Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AvsRegistry tests #360

Merged
merged 11 commits into from
Oct 4, 2024
Merged

Add AvsRegistry tests #360

merged 11 commits into from
Oct 4, 2024

Conversation

TomasArrachea
Copy link
Contributor

@TomasArrachea TomasArrachea commented Sep 27, 2024 •
edited
Loading

Adds tests for the AvsRegistry.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@TomasArrachea TomasArrachea marked this pull request as ready for review September 30, 2024 14:29
pablodeymo
pablodeymo previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@pablodeymo pablodeymo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TomasArrachea TomasArrachea force-pushed the avsregistry_writer_test branch from 98f3798 to 09a9b60 Compare September 30, 2024 20:20
@TomasArrachea TomasArrachea changed the title Add AvsRegistry ChainWriter tests Add AvsRegistry tests Sep 30, 2024
pablodeymo
pablodeymo previously approved these changes Sep 30, 2024
View reviewed changes
@pablodeymo pablodeymo requested a review from afkbyte October 2, 2024 15:37
@afkbyte afkbyte mentioned this pull request Oct 2, 2024
Merged
3 tasks
@TomasArrachea TomasArrachea mentioned this pull request Oct 3, 2024
Merged
3 tasks
@afkbyte afkbyte added this pull request to the merge queue Oct 4, 2024
Merged via the queue into dev with commit 3dfca2a Oct 4, 2024
4 checks passed
@afkbyte afkbyte deleted the avsregistry_writer_test branch October 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afkbyte afkbyte afkbyte approved these changes

@pablodeymo pablodeymo pablodeymo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomasArrachea @pablodeymo @afkbyte