Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shadcn icon #298

Closed
wants to merge 1 commit into from
Closed

add shadcn icon #298

wants to merge 1 commit into from

Conversation

anxkhn
Copy link

@anxkhn anxkhn commented Dec 9, 2024

Add New Icon(s)

Icon Details

Icon ID Icon
shadcn-dark shadcn-dark
shadcn-light shadcn-light

Notes

  • Provide any specific notes about the new icon(s), such as design choices, color adjustments, etc.
  • Mention if there were any deviations from the standard style or guidelines.

Checklist

  • Added icon(s) to the appropriate directory
  • Updated documentation with the new icon(s)
  • Verified the icon(s) display correctly
  • If the icon has light and dark, verified the auto switch works correctly
  • The Svg does not contain any sort of strokes

@anxkhn
Copy link
Author

anxkhn commented Dec 9, 2024

Hi @LelouchFR,
Sorry I couldn't get the location in ascending order in the README, it looks like it will require manually editing rows, please look into it.

Thanks!

Copy link
Owner

@LelouchFR LelouchFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove strokes in the icons for compatibility in the futur (to scale it). please make a shadcn-auto.svg icon

for the readme, dw I can fix that at any moment.

@anxkhn
Copy link
Author

anxkhn commented Dec 11, 2024

please remove strokes
Need some help regarding this, can you please explain why, and also how to perform this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants