Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderFX : pass to remove empty autocast regions #1400

Merged
merged 6 commits into from
Nov 19, 2024
Merged

thunderFX : pass to remove empty autocast regions #1400

merged 6 commits into from
Nov 19, 2024

Conversation

kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Nov 5, 2024 •
edited
Loading

Fixes #1342

IvanYashchuk
IvanYashchuk approved these changes Nov 7, 2024
View reviewed changes
thunder/dynamo/utils.py Outdated Show resolved Hide resolved
thunder/dynamo/utils.py Show resolved Hide resolved
thunder/dynamo/utils.py Show resolved Hide resolved
@kshitij12345 kshitij12345 marked this pull request as ready for review November 7, 2024 17:12
@IvanYashchuk IvanYashchuk mentioned this pull request Nov 8, 2024
Open
@kshitij12345
Copy link
Collaborator Author

Ping @t-vi for review and approval

@kshitij12345 kshitij12345 enabled auto-merge (squash) November 18, 2024 12:14
t-vi
t-vi approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kshitij12345 @IvanYashchuk

@kshitij12345 kshitij12345 merged commit a617503 into Lightning-AI:main Nov 19, 2024
41 checks passed
@mpatel31415 mpatel31415 mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanYashchuk IvanYashchuk IvanYashchuk approved these changes

@t-vi t-vi t-vi approved these changes

@mruberry mruberry Awaiting requested review from mruberry mruberry is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty autocast regions are preserved by Dynamo and given to compilers to optimize
3 participants
@kshitij12345 @IvanYashchuk @t-vi