Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add elu op #1417

Merged
merged 6 commits into from
Nov 13, 2024
Merged

add elu op #1417

merged 6 commits into from
Nov 13, 2024

Conversation

beverlylytle
Copy link
Collaborator

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adds the elu operator.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

mruberry
mruberry reviewed Nov 8, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
mruberry
mruberry reviewed Nov 8, 2024
View reviewed changes
thunder/tests/opinfos.py Outdated Show resolved Hide resolved
@mruberry
Copy link
Collaborator

mruberry commented Nov 8, 2024

Looks great so far!

IvanYashchuk
IvanYashchuk approved these changes Nov 12, 2024
View reviewed changes
thunder/tests/test_grad.py Outdated Show resolved Hide resolved
@IvanYashchuk IvanYashchuk mentioned this pull request Nov 12, 2024
Merged
@beverlylytle beverlylytle marked this pull request as ready for review November 13, 2024 10:00
t-vi
t-vi approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @beverlylytle @mruberry @IvanYashchuk

@beverlylytle
Copy link
Collaborator Author

Thanks @t-vi

@t-vi t-vi merged commit 8f5026f into main Nov 13, 2024
41 checks passed
@t-vi t-vi deleted the add_elu branch November 13, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mruberry mruberry mruberry left review comments

@t-vi t-vi t-vi approved these changes

@IvanYashchuk IvanYashchuk IvanYashchuk approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beverlylytle @mruberry @IvanYashchuk @t-vi