Use the prologue in check_vjp #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beverlylytle
requested review from
mruberry,
lantiga and
t-vi
as code owners
IvanYashchuk
approved these changes
Nov 12, 2024
t-vi
approved these changes
Nov 13, 2024
|
@beverlylytle @IvanYashchuk Merging this added 10 minutes (27->37) to the GPU CI runtime. I wonder if we should use it only for things with keyword args. |
|
Is there a thunder.jit caching option that considers tensor inputs static and keyword arguments dynamic if they are present? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adding support for the elu op (#1417), it was discovered that 'alpha' parameters are not being included in the calculations of jacobian vector products as the prologue is being skipped in this test. Here the prologue is added and the celu op, which also suffers from this inaccuracy, is adapted.