Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add leaky_relu op #1459

Merged
merged 5 commits into from
Nov 27, 2024
Merged

add leaky_relu op #1459

merged 5 commits into from
Nov 27, 2024
+39 −11

Conversation

beverlylytle
Copy link
Collaborator

Before submitting
  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Adds the leaky_relu op.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

t-vi
t-vi reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@t-vi t-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supercool, thank you @beverlylytle

thunder/torch/__init__.py Outdated Show resolved Hide resolved
thunder/tests/opinfos.py Show resolved Hide resolved
@beverlylytle beverlylytle marked this pull request as ready for review November 26, 2024 15:38
mruberry
mruberry reviewed Nov 26, 2024
View reviewed changes
thunder/torch/__init__.py Outdated Show resolved Hide resolved
mruberry
mruberry approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated. Fyi @t-vi re: ci issues

@beverlylytle beverlylytle merged commit ea0159c into main Nov 27, 2024
41 checks passed
@beverlylytle beverlylytle deleted the add_leaky_relu branch November 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-vi t-vi t-vi left review comments

@IvanYashchuk IvanYashchuk IvanYashchuk left review comments

@mruberry mruberry mruberry approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beverlylytle @IvanYashchuk @t-vi @mruberry