Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit docker security settings to clean up CI/CD output #1242

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Feb 20, 2025

Description

  • Solution described here
  • Implications described here

While this reduces the security of these containers (both CICD and docker commands in notebooks), these are intended to be temporary containers without permanent data storage.

... although there are some issues with adding this option to a 'service' in a docker compose

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1 CBroz1 linked an issue Feb 20, 2025 that may be closed by this pull request
@CBroz1 CBroz1 marked this pull request as ready for review February 21, 2025 00:05
@CBroz1 CBroz1 marked this pull request as draft February 21, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI/CD] mbind error makes pytest output hard to read
1 participant