Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit docker security settings to clean up CI/CD output #1242

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ jobs:
ports:
- 3308:3306
options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
cap_add: # https://stackoverflow.com/questions/55559386
- SYS_NICE # CAP_SYS_NICE
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Update URL for DANDI Docs #1210
- Improve cron job documentation and script #1226
- Only add merge parts to `source_class_dict` if present in codebase #1237
- Edit docker security settings to quiet `mbind` warnings #1242

### Pipelines

Expand Down
4 changes: 2 additions & 2 deletions notebooks/00_Setup.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -384,15 +384,15 @@
" - Port mapping. Here, we map 3306 across the local machine and container.\n",
"\n",
" ```bash\n",
" docker run --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0\n",
" docker run --cap-add=sys_nice --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0\n",
" ```\n",
"\n",
"- For data to persist after terminating the container,\n",
" [attach a volume](https://docs.docker.com/storage/volumes/) when running:\n",
"\n",
" ```bash\n",
" docker volume create dj-vol\n",
" docker run --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql\n",
" docker run --cap-add=sys_nice --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql\n",
" ```\n",
"\n",
"Docker credentials are as follows:\n",
Expand Down
4 changes: 2 additions & 2 deletions notebooks/py_scripts/00_Setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,15 @@
# - Port mapping. Here, we map 3306 across the local machine and container.
#
# ```bash
# docker run --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0
# docker run --cap-add=sys_nice --name spyglass-db -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql:8.0
# ```
#
# - For data to persist after terminating the container,
# [attach a volume](https://docs.docker.com/storage/volumes/) when running:
#
# ```bash
# docker volume create dj-vol
# docker run --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql
# docker run --cap-add=sys_nice --name spyglass-db -v dj-vol:/var/lib/mysql -p 3306:3306 -e MYSQL_ROOT_PASSWORD=tutorial datajoint/mysql
# ```
#
# Docker credentials are as follows:
Expand Down