refactor: remove reference solution comparison files #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repository contains reference solution files in
compare
subdirs of model dirs and have extra suffix.cmp
. The MF6 regression test framework has up to now retained the ability to compare with these via the--original-regression
command line flag*.These are omitted from CI in favor of comparing against the latest MF6 release, however. And some comparisons fail, confirmed back to at least 6.4.1
Given that some
*.cmp
files are outdated and they see very limited use, it seems they could be removed.An alternative to these (and to the pattern where we download the previous MF6 release, rebuild it, and run it alongside the development version) could be to snapshot and version output files with a pytest plugin
*Recent autotest refactoring broke this comparison function — the most recent commit in which it works is ad4acb76dfc2a4885623c806efed69181db117a3