test: remove return statement causing checks to be skipped #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
changed the title
* remove return statement causing checks to be skipped * standardize check_output(idx, test) function signature * consolidate framework logging * rename ex to cases in test scripts * use context manager to open files * run black/isort
wpbonelli
force-pushed
the
fix-autotest-framework
branch
from
ac85f0c to
7762a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/cleanup for #1464
checkfunction was skipped if comparison was disabled due to lingeringreturncheck_output(idx, test)signatureextocasesin test scripts