Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend(idm): update fortran dfns for advanced and subpackages #1517

Closed
wants to merge 2 commits into from

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Dec 20, 2023

These updates are forward looking and are intended to support input loading of advanced and subpackages. Advanced packages are marked as such with the already existing # package-type advanced-stress-package tagline in dfn files. A new tag # mf6 subpackage <subp> identifies one subpackage- any number of these can be added to a dfn. The subpackage identifier follows the naming convention for dfn files themselves, so to add TVK to NPF as a subpackage the entire tagline would be # mf6 subpackage utl-tvk.

A subpackage tagline should be added to a package only if both packages are already IDM integrated. This means that each package does not use a parser to read it's own input file but rather sources it's input from the input context.

@mjreno mjreno marked this pull request as draft December 20, 2023 14:55
@mjreno mjreno marked this pull request as ready for review December 22, 2023 12:47
@mjreno mjreno marked this pull request as draft December 27, 2023 16:38
@mjreno mjreno marked this pull request as ready for review January 5, 2024 19:57
@mjreno mjreno added the onhold Waiting for something label Jan 10, 2024
@mjreno mjreno added this to the 6.5.0 milestone Jan 15, 2024
@mjreno mjreno removed the onhold Waiting for something label Jan 15, 2024
@mjreno
Copy link
Contributor Author

mjreno commented Feb 7, 2024

Closing as these changes have been added to PR #1581.

@mjreno mjreno closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant